email_manager - render email body in sandboxed iframe#1521
Merged
Conversation
Prevents stored XSS by rendering email HTML content inside a sandboxed iframe (srcdoc) rather than injecting it directly into the page DOM.
Member
|
Tested and confirm it works. Very low threat as we are the ones generating the HTML that is to be displayed, but little downside to it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Render email body HTML inside a sandboxed
<iframe srcdoc="...">in bothemail_pure.htmlandemail_detail.html, rather than injecting it directly into the page DOM via| safe.This prevents any script content in stored email bodies from executing in the viewer's browser.
Relates to SACGF/variantgrid_private#3828.
Test plan
/email_manager/pure/<id>— body renders correctly in the standalone window